View Issue Details

IDProjectCategoryView StatusLast Update
0004414Talerobsolete componentpublic2016-04-24 21:37
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004414: change error handling technique
DescriptionThis piece of code in funds_mgmt.pu:

   except ValueError:
        return JsonResponse({'reason': 'malformed json'}, status=400)

doesn't make sense in this context.

A ValueError can mean *LOTS* of things in Python, there shouldn't be non-local exception handlers for very general exception types like this.

Please catch such exceptions locally, and convert them to more meaningful ones.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

There are no notes attached to this issue.

Issue History

Date ModifiedUsernameFieldChange
2016-04-11 21:40Florian DoldNew Issue
2016-04-11 21:40Florian DoldStatusnew => assigned
2016-04-11 21:40Florian DoldAssigned To => Marcello Stanisci
2016-04-13 08:59Marcello StanisciSummarynonsensical error handling => change error handling tecnique
2016-04-13 22:53Christian GrothoffSeverityminor => tweak
2016-04-13 22:53Christian GrothoffProduct Version => 0.0
2016-04-13 22:53Christian GrothoffTarget Version => 0.1
2016-04-18 08:02Marcello StanisciStatusassigned => informing
2016-04-18 08:02Marcello StanisciResolutionopen => fixed
2016-04-22 17:44Florian DoldSummarychange error handling tecnique => change error handling technique
2016-04-24 21:37Christian GrothoffStatusinforming => closed
2016-04-24 21:37Christian GrothoffFixed in Version => 0.0
2016-04-24 21:37Christian GrothoffTarget Version0.1 => 0.0
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component