View Issue Details

IDProjectCategoryView StatusLast Update
0012219Talerexchangepublic2026-11-18 17:30
Reporterbot-oec [agent]  
Estimated effort (hours)2 
PrioritynormalSeverityminor 
Status new 
Summary0012219: /melt still accepts new melts in legacy commitment formats; refreshed coins then need not be recoverable from the old coin's history
Descriptiontaler-exchange-httpd_post-melt.c accepts new melts in two legacy formats:

1. LEGACY_VDOLDPLUS_BROKEN (post-melt.c:1002-1032): rc without transfer_pubs. /reveal-melt then recomputes rc without them, so no transfer public key is ever checked.
2. LEGACY_V27 (post-melt.c:952-965, when transfer_pubs is absent): planchet secrets are derived from the coin's EdDSA signature over the nonce (crypto.c:765). EdDSA signatures are not unique, so the derivation cannot be reproduced.

In both cases, cut-and-choose no longer guarantees that the owner of the old coin's private key can re-derive the fresh coins from the coin history plus /reveal-melt. Income transparency then rests only on clients being honest, rather than on the 1/κ bound.

Expected: reject new melts unless rc_version == CURRENT. Keep accepting /reveal-melt (and recoup) for legacy melts that are already stored.

Note: test_exchange_api.c:434-443 currently expects a legacy melt to succeed and would need updating. A regression test (test_exchange_api_melt_legacy) that asserts the rejection is available on branch dev/oec/melt-legacy-regression.

Found by code review at exchange 2a57cbcaf; the regression test confirms that both formats return 200 today.

Docs (minor): post-reveal-melt.rst gives the HKDF argument order for the batch seeds as (old_coin_priv, refresh_seed). The code and post-melt.rst use (refresh_seed, old_coin_priv).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

There are no notes attached to this issue.

Issue History

Date ModifiedUsernameFieldChange
2026-11-18 17:29bot-oecNew Issue
2026-11-18 17:29bot-oecImplementer => oec
2026-11-18 17:29bot-oecReviewer => Christian Grothoff
2026-11-18 17:29bot-oecRelease signed by => Florian Dold
2026-11-18 17:29bot-oecDeployed by => Christian Grothoff
2026-11-18 17:29bot-oecVerifier => oec
2026-11-18 17:29bot-oecCommunicator => CM_7
2026-11-18 17:30oecEstimated effort (hours) => 2