View Issue Details

IDProjectCategoryView StatusLast Update
0012182Talertaler-rustpublic2026-11-18 15:57
Reporterbot-cg [agent]  
ImplementerAntoine A  
Fast-trackYes — The control, the release and the deployment are skipped: whoever implemented this change verifies and closes it themselves.
PrioritynormalSeveritytrivial 
Status implementing 
Summary0012182: taler-api: answer a body that cannot be read with 400
DescriptionGENERIC_UNEXPECTED_REQUEST_ERROR has no HTTP status in the registry, so building the response for a failed body read panicked.

Files: common/taler-api/src/extract.rs (paths in the taler-rust tree). The patch is attached; it is number 7 of the series in the parent issue, against taler-rust 2c678873, and applies on top of the patches before it.
TagsNo tags attached.
Attached Files
0007-api-answer-a-body-that-cannot-be-read-with-400.patch (1,205 bytes)   
From 8dc2579ca36fa38ca3004c85e0a3b8f45e1d0ec9 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Wed, 18 Nov 2026 10:43:58 +0100
Subject: [PATCH 7/9] api: answer a body that cannot be read with 400

GENERIC_UNEXPECTED_REQUEST_ERROR has no HTTP status in the registry, so
building the response for a failed body read panicked.
---
 common/taler-api/src/extract.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/taler-api/src/extract.rs b/common/taler-api/src/extract.rs
index 5a6f22d..3bc2676 100644
--- a/common/taler-api/src/extract.rs
+++ b/common/taler-api/src/extract.rs
@@ -120,9 +120,12 @@ pub async fn decompressed_strict_body_limited(
                 ));
             }
             Err(err) => {
-                return Err(failure(
+                // The registry gives this code no HTTP status, and building
+                // the response would panic.
+                return Err(failure_status(
                     ErrorCode::GENERIC_UNEXPECTED_REQUEST_ERROR,
                     format!("Failed to read body: {err}"),
+                    StatusCode::BAD_REQUEST,
                 ));
             }
         },
-- 
2.47.3

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0012175 implementing taler-api: nine patches that Beekeeper carries on its vendored copy (patch series attached) 

Activities

bot-cg [agent]

2026-11-18 14:42

updater   ~0030581

Correction: this issue was filed in the category "exchange" by mistake. It concerns taler-rust (common/taler-api or common/taler-common), like its parent 0012175, and belongs in the category "taler-rust". This reporter account cannot change the category; could someone with updater rights move it?

Issue History

Date ModifiedUsernameFieldChange
2026-11-18 14:41bot-cgNew Issue
2026-11-18 14:41bot-cgRelationship addedchild of 0012175
2026-11-18 14:41bot-cgImplementer => oec
2026-11-18 14:41bot-cgReviewer => Christian Grothoff
2026-11-18 14:41bot-cgRelease signed by => Christian Grothoff
2026-11-18 14:41bot-cgDeployed by => Christian Grothoff
2026-11-18 14:41bot-cgVerifier => oec
2026-11-18 14:41bot-cgCommunicator => CM_7
2026-11-18 14:42bot-cgFile Added: 0007-api-answer-a-body-that-cannot-be-read-with-400.patch
2026-11-18 14:42bot-cgNote Added: 0030581
2026-11-18 15:54Christian GrothoffCategoryexchange => taler-rust
2026-11-18 15:56Christian GrothoffSeverityminor => trivial
2026-11-18 15:56Christian GrothoffStatusnew => implementing
2026-11-18 15:57Christian GrothoffFast-track0 => 1
2026-11-18 15:57Christian GrothoffImplementeroec => Antoine A