View Issue Details

IDProjectCategoryView StatusLast Update
0012174Talerwallet (iOS App)public2026-11-18 14:25
Reporterbot-cg [agent]  
PrioritynormalSeverityminor 
Status new 
Summary0012174: 1.6.19 onboarding bubble covers "Get demo cash" on a fresh wallet: its text overlaps the card's text, and the first tap on the button only dismisses the bubble
DescriptionVersion 1.6.19 (master 42075050, commit a9f22bf0 "Bubble Onboarding").

On a fresh wallet the new onboarding hint ("Tap the Actions button to start
transactions, or scan a QR code.") is drawn over the lower part of the first
screen. On the empty-wallet screen that is exactly where the demo card is:

  1. the hint's text is drawn on top of "Get demo cash to experience how to
     pay with digital cash." -- two texts on top of each other, neither
     readable (see onboarding-bubble-over-demo-cash.jpg);
  2. the hint covers the "Get demo cash" button, and it takes the tap: the
     first tap on the button only dismisses the hint. Nothing else happens;
     the user has to tap the button a second time.

Measured (iPhone 17 simulator, iOS 27.2, 402x874 points, English): the hint
occupies [x 0, y 615, w 402, h 225]; the button is at [16, 697, 370, 77] and
the sentence above it at [16, 621, 370, 77]. Both lie entirely inside the
hint.

Reproduction: install 1.6.19 on a device with no wallet data, launch, tap
"Get demo cash".
Observed: the hint disappears, no withdrawal starts (no withdrawTestBalance
request in the log). A second tap starts it.
Expected: the hint does not cover the screen's primary action, and a tap on a
visible button presses that button.

How it was found: the UI test suite's first step on a fresh wallet is that
tap; on 1.6.19 every scenario that starts this way failed at it.

Cause (TalerWallet1/Views/Main/WalletMain.swift): ActionsBubble is the last
child of the main ZStack(alignment: .bottom) and ends with

    .contentShape(.rect)
    .onTapGesture { showIt = false }

so its whole rectangle, including the transparent padding around the
coloured shape, is a tap target above the content.

Patch (attached, bubble-swallows-tap.diff): the bubble no longer takes hits
(.allowsHitTesting(false)) and the ZStack dismisses it on any tap with a
simultaneous gesture, so the first tap both removes the hint and reaches the
button under it. Tested on master + patch: the same scenario now passes (the
tap dismisses the hint and the demo withdrawal starts).

The patch fixes item 2 only. Item 1 (the hint drawn over the card's text)
needs a layout decision -- e.g. not showing the hint while the empty-wallet
cards are on screen, or reserving space for it -- which I have not attempted.
TagsNo tags attached.
Attached Files
bubble-swallows-tap.diff (1,424 bytes)   
diff --git a/TalerWallet1/Views/Main/WalletMain.swift b/TalerWallet1/Views/Main/WalletMain.swift
index 974c788d..24b6582c 100755
--- a/TalerWallet1/Views/Main/WalletMain.swift
+++ b/TalerWallet1/Views/Main/WalletMain.swift
@@ -332,6 +332,9 @@ struct WalletMain: View {
             }
             ActionsBubble(showIt: $showBubble, isShowing: isShowing)
         } // ZStack
+        .simultaneousGesture(TapGesture().onEnded {
+            if showBubble { showBubble = false }        // any tap dismisses the hint, and still reaches its target
+        })
         .frame(maxWidth: .infinity, maxHeight: .infinity)
         .onNotification(.SendAction)    { notification in
             if let actionType = notification.userInfo?[NOTIFICATIONANIMATION] as? ActionType {
@@ -463,10 +466,10 @@ struct ActionsBubble: View {
                         .padding(.horizontal, 30)
                 }
                 .padding(.bottom, Bool.iOS26 ? 70 : 90)
-                .contentShape(.rect)
-                .onTapGesture {
-                    showIt = false
-                }
+                // The bubble lies over whatever is at the bottom of the screen - on an empty wallet
+                // that is the "Get demo cash" button. It must not take the tap meant for the button
+                // below it; the ZStack dismisses the bubble on any tap instead.
+                .allowsHitTesting(false)
         }
     }
 }
bubble-swallows-tap.diff (1,424 bytes)   

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Issue History

Date ModifiedUsernameFieldChange
2026-11-18 14:25bot-cgNew Issue
2026-11-18 14:25bot-cgImplementer => MarcS
2026-11-18 14:25bot-cgReviewer => avalos
2026-11-18 14:25bot-cgDeployed by => mikolai
2026-11-18 14:25bot-cgVerifier => Bohdan
2026-11-18 14:25bot-cgCommunicator => CM_7
2026-11-18 14:25bot-cgFile Added: onboarding-bubble-over-demo-cash.jpg
2026-11-18 14:25bot-cgFile Added: bubble-swallows-tap.diff