View Issue Details

IDProjectCategoryView StatusLast Update
0012156Talerwallet (iOS App)public2026-11-16 10:24
Reporterbot-cg [agent]  
PrioritynormalSeveritymajor 
Status new 
Summary0012156: Deposit that needs proof of account control (KYC auth) shows "KYC Error / No IBAN" for x-taler-bank and Cyclos accounts instead of the transfer instructions (patch attached)
DescriptionA deposit that the payment service will only complete after the user has
proved control of the destination account ("KYC auth": a small wire transfer
from that account) shows, for any destination that is not an IBAN,

    KYC Error
    No IBAN
    [OK]

and nothing else. The instructions for the proving transfer -- which the
payment service did send -- are not shown, so the user cannot finish the
deposit and is not told what is being asked (deposit-kyc-auth-no-iban.jpg).

Steps (iOS 27.2 simulator; a test exchange with a KYC rule on deposits,
OPERATION_TYPE = DEPOSIT, threshold KUDOS:0.1):
 1. Withdraw KUDOS 3 from that exchange.
 2. Settings -> Bank Accounts -> + -> X-TALER-BANK, enter an account.
 3. Actions -> Deposit -> that account -> KUDOS 1.00 -> Deposit.
 4. The deposit goes to pending (kyc-auth) and its page shows the error.

Bank Accounts offers IBAN, x-taler-bank and Cyclos as account types, so two
of the three kinds of account a user can add lead here.

Cause (Views/Transactions/KYCauth.swift), with the open question already in
the source:

    let debitPayTo = PayTo(info.debitPaytoUri)
    if let debitIban = debitPayTo.iban {
        ... WireTransferView(...)
    } else {
        // TODO: What if payto contains no IBAN, but URL?
        ErrorView(stack.push(), title: kycErr, message: String(localized: "No IBAN"))
    }

Patch (kycauth-non-iban.diff, built and run): take the account from the IBAN,
the Cyclos address or the x-taler-bank address, whichever the destination is.
(PayTo.xTaler cannot be used for this: it is set to the text "unknown payment
method" for every address that is not x-taler-bank, so the patch asks the URL
directly.) With it the same deposit shows "You need to prove having control
over the bank account for the deposit of KUDOS 1.00", the amount to transfer
and "Wire transfer instructions" (deposit-kyc-auth-patched.jpg).

Not covered by the patch: the instruction texts further down say "from
<IBAN>" and were written for an IBAN; for the other account kinds they now
print the account address in that place, which reads acceptably but should be
looked at by someone who knows the intended wording. I have only run the
x-taler-bank case, not Cyclos.

Found by the UI fuzz harness (scenario deposit-kyc, 2026-11-16) once the test
setup had a deposit that could reach this state.
TagsNo tags attached.
Attached Files
deposit-kyc-auth-no-iban.jpg (26,306 bytes)   
deposit-kyc-auth-no-iban.jpg (26,306 bytes)   
deposit-kyc-auth-patched.jpg (35,820 bytes)   
deposit-kyc-auth-patched.jpg (35,820 bytes)   
kycauth-non-iban.diff (1,844 bytes)   
diff --git a/TalerWallet1/Views/Transactions/KYCauth.swift b/TalerWallet1/Views/Transactions/KYCauth.swift
index c7624100..ee349db3 100755
--- a/TalerWallet1/Views/Transactions/KYCauth.swift
+++ b/TalerWallet1/Views/Transactions/KYCauth.swift
@@ -27,7 +27,14 @@ struct KYCauth: View {
         let kycErr = String(localized: "KYC Error")
         if let info = common.kycAuthTransferInfo {
             let debitPayTo = PayTo(info.debitPaytoUri)
-            if let debitIban = debitPayTo.iban {
+            // Not every account a deposit can go to is an IBAN: x-taler-bank and Cyclos
+            // accounts can be added in Bank Accounts too, and the payment service asks for
+            // the same proof of control for them. (PayTo.xTaler is not usable here: it is
+            // set to a placeholder text for every address that is not x-taler-bank.)
+            let debitAccount = debitPayTo.iban
+                            ?? debitPayTo.cyclos
+                            ?? URL(string: info.debitPaytoUri)?.xTaler
+            if let debitIban = debitAccount {
                 let accountDetails = info.transferOptionsExt
                 if let validDetails = accountDetails.validDetails {
                     if let scope: ScopeInfo = common.scopes.first {
@@ -44,7 +51,6 @@ struct KYCauth: View {
                     } else { ErrorView(stack.push(), title: kycErr, message: String(localized: "No scope")) }
                 } else { ErrorView(stack.push(), title: kycErr, message: String(localized: "No valid details")) }
             } else {
-                // TODO: What if payto contains no IBAN, but URL?
                 ErrorView(stack.push(), title: kycErr, message: String(localized: "No IBAN"))
             }
         } else { ErrorView(stack.push(), title: kycErr, message: String(localized: "No KYC infos")) }
kycauth-non-iban.diff (1,844 bytes)   

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Issue History

Date ModifiedUsernameFieldChange
2026-11-16 10:24bot-cgNew Issue
2026-11-16 10:24bot-cgImplementer => MarcS
2026-11-16 10:24bot-cgReviewer => avalos
2026-11-16 10:24bot-cgDeployed by => mikolai
2026-11-16 10:24bot-cgVerifier => Bohdan
2026-11-16 10:24bot-cgCommunicator => CM_7
2026-11-16 10:24bot-cgFile Added: deposit-kyc-auth-no-iban.jpg
2026-11-16 10:24bot-cgFile Added: deposit-kyc-auth-patched.jpg
2026-11-16 10:24bot-cgFile Added: kycauth-non-iban.diff