View Issue Details

IDProjectCategoryView StatusLast Update
0012153Talerwallet (iOS App)public2026-11-16 01:13
Reporterbot-cg [agent]  
ImplementerMarcS  
PrioritynormalSeverityminor 
Status implementing 
Target Version1.7 
Summary0012153: Transaction pages that offer the user no way to remove the transaction: Suspend/Resume are developer-only, Retry is never shown, and nothing is shown while the connection is stalled
DescriptionThe transaction page (TransactionSummaryList) shows exactly the actions
wallet-core lists in txActions: isDeleteable / isAbortable / isFailable are
txActions.contains(...) (Transaction.swift:398-400), with no fallback. Where
wallet-core lists none of delete, abort, fail (see the wallet-core sibling of
this issue), what the app adds on top decides whether the user sees anything
at all. Three things make that worse on iOS.

1. Suspend and Resume are shown in developer mode only
   (`if developerMode && withActions { suspendResume(common) }`,
   TransactionSummaryList.swift:316). For a state whose only actions are
   Suspend and Retry, a normal user sees no action.
2. Retry is decoded (TxAction.retry, with a title and an icon) and never
   rendered by any view.
3. While controller.stalledConnection is set, the page shows neither the
   details nor the action buttons
   (`if !controller.stalledConnection { ... if withActions { abortFailDelete(common) } }`,
   :334-343). A transaction that is stuck BECAUSE the payment service is
   unreachable is the one the user most wants to abort or delete.

Recorded example (10 fuzzing episodes, e.g. c2h-10-e00004 screen 32, developer
mode ON): a bank-integrated withdrawal waiting for the user's legitimization.
The page shows

    Pending / Withdrawal / [Suspend] / 9 November 2026 at 14:10 / kyc
    "You need to pass a legitimization procedure." [Open legitimization website]

and nothing else. With developer mode off, the Suspend button is gone too. A
user who will not do the KYC keeps this withdrawal in the wallet for good.

Also: refresh transactions are requested only in developer mode
(includeRefreshes: developerMode, BalancesSectionView.swift:71,88,97, and
false for the recent list :62). A refresh that failed or hangs is invisible
to a normal user, and so cannot be deleted by one.

Suggested, in order of how little they change: show the action buttons also
when the connection is stalled; show Retry; and decide per state what a user
who wants the entry gone is offered ("abandon and accept the loss" being a
legitimate, if hard, answer). No patch: the last point is a product decision
that belongs with the wallet-core sibling.
TagsNo tags attached.
Attached Files
12153-retry-and-actions-while-stalled.diff (3,544 bytes)   
diff --git a/TalerWallet1/Model/Model+Transactions.swift b/TalerWallet1/Model/Model+Transactions.swift
index 60a4ec3a..896bd275 100755
--- a/TalerWallet1/Model/Model+Transactions.swift
+++ b/TalerWallet1/Model/Model+Transactions.swift
@@ -147,6 +147,17 @@ struct ResumeTransaction: WalletBackendFormattedRequest {
         var transactionId: String
     }
 }
+/// A request to retry a wallet transaction now instead of waiting for its back-off.
+struct RetryTransaction: WalletBackendFormattedRequest {
+    struct Response: Decodable {}   // no result - getting no error back means success
+    var operation: String { "retryTransaction" }
+    func args() -> Args { Args(transactionId: transactionId) }
+
+    var transactionId: String
+    struct Args: Encodable {
+        var transactionId: String
+    }
+}
 // MARK: -
 extension WalletModel {
     /// ask wallet-core for its list of transactions filtered by state
@@ -198,4 +209,10 @@ extension WalletModel {
         logger.notice("resumeTransaction: \(transactionId, privacy: .private(mask: .hash))")
         _ = try await sendRequest(request, viewHandles: viewHandles)
     }
+
+    nonisolated func retryTransaction(transactionId: String, viewHandles: Bool = false) async throws {
+        let request = RetryTransaction(transactionId: transactionId)
+        logger.notice("retryTransaction: \(transactionId, privacy: .private(mask: .hash))")
+        _ = try await sendRequest(request, viewHandles: viewHandles)
+    }
 }
diff --git a/TalerWallet1/Views/Transactions/TransactionSummaryList.swift b/TalerWallet1/Views/Transactions/TransactionSummaryList.swift
index d475186d..c03c4cdf 100755
--- a/TalerWallet1/Views/Transactions/TransactionSummaryList.swift
+++ b/TalerWallet1/Views/Transactions/TransactionSummaryList.swift
@@ -245,6 +245,16 @@ struct TransactionSummaryList: View {
 
     @ViewBuilder
     func abortFailDelete(_ common: TransactionCommon) -> some View {
+        // wallet-core offers Retry in every waiting state, and in some of them nothing else
+        // (e.g. a funded withdrawal that waits for the payment service). It was decoded,
+        // titled and given an icon, and no view ever showed it.
+        if talerTX.isRetryable {
+            TransactionButton(transactionId: common.transactionId,
+                                    command: .retry,
+                                    warning: nil,
+                                 didExecute: $ignoreThis,
+                                     action: model.retryTransaction)
+        } // Retry button
         if talerTX.isAbortable {
             let warning = String(localized: "Are you sure you want to abort this transaction?")
             TransactionButton(transactionId: common.transactionId,
@@ -340,8 +350,10 @@ struct TransactionSummaryList: View {
                                       effective: $effective,    // return amount for "Pay <amount> now"
                                        possible: $paymentPossible,
                                         hasDone: hasDone)
-                    if withActions { abortFailDelete(common) }
                 }
+                // Not inside the check above: a transaction that is stuck BECAUSE the payment
+                // service cannot be reached is the one the user most wants to abort or delete.
+                if withActions { abortFailDelete(common) }
             }.id(viewId)    // change viewId to enforce a draw update
             .listStyle(myListStyle.style).anyView
             .background(FullBackground())

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0012147 implementing iOS wallet: state the user can never delete -- audit against the rule that every item must be individually removable [meta] 

Activities

bot-cg [agent]

2026-11-16 01:13

updater   ~0030538

A patch for the two parts of this that need no product decision
(12153-retry-and-actions-while-stalled.diff). It compiles (BUILD SUCCEEDED,
Debug, iOS simulator, 2026-11-16, on top of the 12142 patch which touches the
same file); it has NOT been run against a transaction in such a state.

 1. Retry. Adds the retryTransaction request to the model and renders the
    button whenever wallet-core lists the action (isRetryable). Title, icon
    and progress text for it already existed.
 2. The Abort / Abandon / Delete buttons are no longer inside
    `if !controller.stalledConnection`, so a transaction stuck because the
    payment service cannot be reached can still be aborted or deleted.

Not in the patch: making Suspend / Resume available outside developer mode,
and what to offer in the states where wallet-core lists neither delete, abort
nor fail (12154).

Issue History

Date ModifiedUsernameFieldChange
2026-11-15 19:38bot-cgNew Issue
2026-11-15 19:38bot-cgRelationship addedchild of 0012147
2026-11-15 19:38bot-cgImplementer => MarcS
2026-11-15 19:38bot-cgReviewer => bernaalp
2026-11-15 19:38bot-cgDeployed by => mikolai
2026-11-15 19:38bot-cgVerifier => Florian Dold
2026-11-15 19:38bot-cgCommunicator => CM_7
2026-11-15 20:09Christian GrothoffReviewerbernaalp => avalos
2026-11-15 20:09Christian GrothoffRelease signed by => MarcS
2026-11-15 20:09Christian GrothoffDeployed bymikolai => MarcS
2026-11-15 20:09Christian GrothoffStatusnew => implementing
2026-11-15 20:09Christian GrothoffTarget Version => 1.7
2026-11-16 01:13bot-cgFile Added: 12153-retry-and-actions-while-stalled.diff
2026-11-16 01:13bot-cgNote Added: 0030538