View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011621 | Taler | wallet (Android App) | public | 2026-07-09 09:07 | 2026-11-11 02:05 |
| Reporter | vecirex | Assigned To | Resolution deadline | ||
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | implementing | Resolution | open | ||
| Target Version | 1.7 | ||||
| Summary | 0011621: taler-uri-action "add-exchange" missing | ||||
| Description | In Android, taler://add-exchange/$EXCHANGE_DOMAIN/ doesn't seem to work, claims to be unsupported URI. See this described in https://lsd.gnunet.org/lsd0006 and https://docs.taler.net/wallet/wallet-core.html#addexchangeop to exist; cf. screenshot. | ||||
| Tags | android, quality, ux | ||||
| Attached Files | |||||
| related to | 0012106 | new | iOS: taler://add-exchange link hangs on "Scanning..." for ever (ExchangeListView clears URLSheet's URL binding) |
| Acc. to marc, fixed to be supported already in iOS; not visible in git (afaics), probably local. | |
| Still the case on Android master (4c483527, 2026-11-11); fresh screenshots and a patch attached. taler://add-exchange/tripwire.taler.net:8445/ on Android: error sheet "Error / Unsupported URI: taler://add-exchange/tripwire.taler.net:8445/" (before-android-1.png). HandleUriScreen.kt:85-152 has branches for pay, withdraw, withdraw-exchange, refund, pay-pull, pay-push, pay-template, dev-experiment and add-contact only; the else branch builds the untranslated "Unsupported URI" text (:149-151). WebExtension: "Add exchange / Add https://tripwire.taler.net:8445/ as a wallet exchange." -> Continue -> exchange details (before-web-1.png, before-web-2.png). iOS: on current master the same link hangs on "Scanning..." (before-ios-1.png); filed separately with a fix as 0012106. Patch (android-add-exchange-uri.patch, 6 lines in HandleUriScreen.kt): an "add-exchange/" branch that calls ExchangeManager.add(uri) (wallet-core's addExchange parses taler://add-exchange URIs itself) and opens Settings > Payment services, which already reports add failures in a snackbar. Built with :wallet:assembleFdroidSim; the link now adds the exchange and shows it in the list (after-android-1.png). Assisted by LLM android-add-exchange-uri.patch (1,066 bytes)
diff --git a/wallet/src/main/java/net/taler/wallet/HandleUriScreen.kt b/wallet/src/main/java/net/taler/wallet/HandleUriScreen.kt
index 03a3c56a..56c005e1 100644
--- a/wallet/src/main/java/net/taler/wallet/HandleUriScreen.kt
+++ b/wallet/src/main/java/net/taler/wallet/HandleUriScreen.kt
@@ -100,6 +100,12 @@ fun HandleUriScreen(
editableCurrency = false
), true)
}
+ action.startsWith("add-exchange/", ignoreCase = true) -> {
+ // wallet-core parses the taler://add-exchange URI itself;
+ // the list reports a failure (snackbar) and shows the new entry
+ model.exchangeManager.add(u2)
+ onNavigate(WalletDestination.ExchangeList, true)
+ }
action.startsWith("withdraw-exchange/", ignoreCase = true) -> {
model.withdrawManager.resetWithdrawal()
onNavigate(WalletDestination.PromptWithdraw(
| |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-07-09 09:07 | vecirex | New Issue | |
| 2026-07-09 09:07 | vecirex | File Added: android-without-add-exchange-taler-uri-action.jpg | |
| 2026-07-09 09:07 | vecirex | Tag Attached: android | |
| 2026-07-09 09:07 | vecirex | Tag Attached: quality | |
| 2026-07-09 09:07 | vecirex | Tag Attached: ux | |
| 2026-07-09 09:11 | vecirex | Tag Attached: compliance | |
| 2026-07-09 09:11 | vecirex | Tag Detached: compliance | |
| 2026-07-10 09:37 | Christian Grothoff | Status | new => implementing |
| 2026-07-10 10:17 | vecirex | Note Added: 0029131 | |
| 2026-07-10 10:17 | vecirex | Note Edited: 0029131 | |
| 2026-08-29 19:37 | Florian Dold | Target Version | => 1.7 |
| 2026-11-11 02:05 | bot-cg | Note Added: 0030401 | |
| 2026-11-11 02:05 | bot-cg | File Added: before-android-1.png | |
| 2026-11-11 02:05 | bot-cg | File Added: before-web-1.png | |
| 2026-11-11 02:05 | bot-cg | File Added: before-web-2.png | |
| 2026-11-11 02:05 | bot-cg | File Added: before-ios-1.png | |
| 2026-11-11 02:05 | bot-cg | File Added: after-android-1.png | |
| 2026-11-11 02:05 | bot-cg | File Added: android-add-exchange-uri.patch |