View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006194 | Taler | exchange | public | 2020-04-21 14:56 | 2021-08-24 16:23 |
| Reporter | fefe | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | text | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.7.0 | ||||
| Target Version | 0.7.1 | Fixed in Version | 0.7.1 | ||
| Summary | 0006194: serialize_denomination_key NULL case looks fishy | ||||
| Description | In exchange/src/lib/exchange_api_refresh_common.c: 214 * @return number of bytes written to @a buf at @a off, or if 215 * @a buf is NULL, number of bytes required This is slightly ambiguous. Does the number of bytes required include off or not? Turns out: it does not: 228 if (NULL == buf) 229 { 230 GNUNET_free (pbuf); 231 return pbuf_size + sizeof (uint32_t); 232 } This is the behavior expected by the only caller. Recommendation: make the comment clearer. Maybe add an "additional" or so. | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-04-21 14:56 | fefe | New Issue | |
| 2020-04-21 14:56 | fefe | Status | new => assigned |
| 2020-04-21 14:56 | fefe | Assigned To | => Christian Grothoff |
| 2020-04-21 15:01 | Christian Grothoff | Status | assigned => resolved |
| 2020-04-21 15:01 | Christian Grothoff | Resolution | open => fixed |
| 2020-04-21 15:01 | Christian Grothoff | Fixed in Version | => 0.7.1 |
| 2020-04-21 15:01 | Christian Grothoff | Note Added: 0015726 | |
| 2020-04-21 15:01 | Christian Grothoff | Target Version | => 0.7.1 |
| 2021-08-24 16:23 | Christian Grothoff | Status | resolved => closed |
