View Issue Details

IDProjectCategoryView StatusLast Update
0006192Talerexchangepublic2021-09-02 18:14
ReporterMarcello Stanisci Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.7.1Fixed in Version0.7.1 
Summary0006192: Avoid substituting valid HTTP status code with 0, when a condition fails.
DescriptionThe http client artifact used by the exchange _substitutes_ a valid response status code with 0 whenever the JSON parser is not
happy about something. This way is harder to understand what happened. For example, a server might have returned 404 but didn't include a 'ec' field in the response, and the testcase ends everything saying that the response had '0' as status code.
Additional InformationThe problem was observed with a invalid JSON, but that doesn't mean it doesn't exist when other conditions could fail.
TagsNo tags attached.

Activities

Christian Grothoff

2020-04-21 13:58

manager   ~0015722

Fixed in a5460cc8..c167fd8f

Christian Grothoff

2021-09-02 18:14

manager   ~0018261

Fix committed to master branch.

Related Changesets

exchange: master c167fd8f

2020-04-21 15:53

Christian Grothoff


Details Diff
fix 0006192 Affected Issues
0006192
mod - src/bank-lib/bank_api_admin.c Diff File
mod - src/bank-lib/bank_api_credit.c Diff File
mod - src/bank-lib/bank_api_debit.c Diff File
mod - src/bank-lib/bank_api_transfer.c Diff File

Issue History

Date Modified Username Field Change
2020-04-21 13:39 Marcello Stanisci New Issue
2020-04-21 13:39 Marcello Stanisci Status new => assigned
2020-04-21 13:39 Marcello Stanisci Assigned To => Christian Grothoff
2020-04-21 13:58 Christian Grothoff Status assigned => resolved
2020-04-21 13:58 Christian Grothoff Resolution open => fixed
2020-04-21 13:58 Christian Grothoff Fixed in Version => 0.7.1
2020-04-21 13:58 Christian Grothoff Note Added: 0015722
2020-04-21 13:58 Christian Grothoff Product Version => git (master)
2020-04-21 13:58 Christian Grothoff Target Version => 0.7.1
2021-08-24 16:23 Christian Grothoff Status resolved => closed
2021-09-02 18:13 Christian Grothoff Changeset attached => Taler-exchange master c167fd8f
2021-09-02 18:14 Christian Grothoff Note Added: 0018261