View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006129 | Taler | specification | public | 2020-03-17 12:37 | 2021-09-02 18:23 |
Reporter | grote | Assigned To | Christian Grothoff | ||
Priority | high | Severity | major | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | git (master) | ||||
Target Version | 0.7.1 | Fixed in Version | 0.7.1 | ||
Summary | 0006129: Merchant API not idempotent, does not behave as documented | ||||
Description | This relates to the refund API: https://docs.taler.net/core/api-merchant.html#giving-refunds I've been testing this and when sending a `RefundRequest` POST request, I get back: { "sig": "5TJNEY2W9DB...", "contract_terms": { ... }, "taler_refund_uri": "taler:\/\/refund\/backend.test.taler.net\/-\/-\/2020..." } which is fine, but not exactly a `MerchantRefundResponse` as documented. Also, when doing the same request again, I get a 409 error. Which is not so nice if for some reason, the merchant went back and needs to let the customer scan again. So I tried an undocumented GET request and there I get something that looks almost like a MerchantRefundResponse, but there's no refund_redirect_url. So if I missed the URL the first time, there seems to be no way to get it back. | ||||
Tags | No tags attached. | ||||
|
Fixed in 7cfd98c..e781a77: The API should now be idempotent AND follow the updated and simplified specification. |
|
Fix committed to master branch. |
merchant: master e781a77a 2020-04-07 20:47 Details Diff |
fix 0006129 (/refund idempotency) |
Affected Issues 0006129 |
|
mod - src/backend/taler-merchant-httpd_refund_increase.c | Diff File | ||
mod - src/backend/taler-merchant-httpd_refund_lookup.c | Diff File | ||
mod - src/backenddb/plugin_merchantdb_postgres.c | Diff File | ||
mod - src/backenddb/test_merchantdb.c | Diff File | ||
mod - src/include/taler_merchantdb_plugin.h | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-03-17 12:37 | grote | New Issue | |
2020-03-17 12:37 | grote | Status | new => assigned |
2020-03-17 12:37 | grote | Assigned To | => Christian Grothoff |
2020-04-07 16:12 | Christian Grothoff | Priority | normal => high |
2020-04-07 16:12 | Christian Grothoff | Severity | minor => major |
2020-04-07 16:12 | Christian Grothoff | Product Version | => git (master) |
2020-04-07 16:12 | Christian Grothoff | Target Version | => 0.7.1 |
2020-04-07 18:53 | Christian Grothoff | Status | assigned => resolved |
2020-04-07 18:53 | Christian Grothoff | Resolution | open => fixed |
2020-04-07 18:53 | Christian Grothoff | Fixed in Version | => 0.7.1 |
2020-04-07 18:53 | Christian Grothoff | Note Added: 0015562 | |
2021-08-24 16:23 | Christian Grothoff | Status | resolved => closed |
2021-09-02 18:22 | Christian Grothoff | Changeset attached | => Taler-merchant master e781a77a |
2021-09-02 18:23 | Christian Grothoff | Note Added: 0018382 | |
2024-01-12 14:02 | Christian Grothoff | Category | merchant backend API (HTTP specification) => specification |