View Issue Details

IDProjectCategoryView StatusLast Update
0005282Talerotherpublic2021-08-24 16:23
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0005282: style demo pages for better usability on mobile
DescriptionNow that Firefox on Android can use the Taler wallet, we should make sure that the demo is less awkward to use on mobile.

Currently the layout is not fit at all for smaller screens.
TagsNo tags attached.

Activities

LUG

2019-02-01 22:38

reporter   ~0013556

I was trying to push changes addressing the mobile friendliness to feature/mobile-friendly but get the following git error:
"fatal: remote error: access denied or repository not exported: /landing.git

What's the contribution workflow here?

Christian Grothoff

2019-02-02 10:49

manager   ~0013557

For now, please attach patches to the bug report; if we find you're a consistent contributor, we'll give you the ability to push changes directly to our main Git.

LUG

2019-04-26 20:18

reporter   ~0014349

I'm giving this another try.
@Florian, have you done something in that direction already that I should consider or do I start from the latest repo version?

nikita

2019-07-15 15:43

reporter   ~0014675

ack. Will work on this after GSoC.

nikita

2019-09-04 20:12

reporter   ~0014858

<code>
      <h2>Step 4: Check money flow</sup></h2>
</code>

is there any purpose for these seemingly misplaced sup tags I don't get immediately?

nikita

2019-09-04 20:14

reporter   ~0014859

I would just remove them, but there are too many of them to be random mistakes:

./demo/common/base.j2:81: <h2>Step 3: Pay</sup></h2>
./demo/common/base.j2:97: <h2>Step 4: Back office</sup></h2>
./demo/common/base.j2:113: <h2>Step 5: Reach out to us</sup></h2>
./demo/index.html.j2:84: <h2>Step 3: Pay</sup></h2>
./demo/index.html.j2:100: <h2>Step 4: Check money flow</sup></h2>
./demo/index.html.j2:112: <h2>Step 5: Merchant? Consult back-office</sup></h2>
./demo/index.html.j2:121: <h2>Step 6: Reach out to us</sup></h2>

nikita

2019-09-04 20:20

reporter   ~0014860

I have to ask because:

> The HTML Superscript element (<sup>) specifies inline text which is to be displayed as superscript for solely typographical reasons. Superscripts are usually rendered with a raised baseline using smaller text.

I assume it's leftover code unless you use this for something I have yet to find in the other code bases?

nikita

2019-09-04 20:46

reporter   ~0014861

sorry for the noise. 2 more git wrapper scripts later and finding 4767b306 in the repository: those are leftovers.

Florian Dold

2019-09-05 16:39

manager   ~0014866

It's very likely some left-over markup from copy&pasting the headings. It can definitely be removed.

Christian Grothoff

2020-10-11 21:09

manager   ~0017010

I've fixed the </sup> tags.

Christian Grothoff

2020-10-11 21:11

manager   ~0017011

I think the new style by Torsten is mobile-friendly, at least for my tests.

Note that there is still a 404 issue with respect to test.taler.net and some CSS file. Still: closing this one.

Issue History

Date Modified Username Field Change
2018-02-20 16:18 Florian Dold New Issue
2019-02-01 22:38 LUG Note Added: 0013556
2019-02-02 10:49 Christian Grothoff Note Added: 0013557
2019-04-26 20:18 LUG Note Added: 0014349
2019-07-15 15:43 nikita Assigned To => nikita
2019-07-15 15:43 nikita Status new => acknowledged
2019-07-15 15:43 nikita Note Added: 0014675
2019-09-04 20:12 nikita Note Added: 0014858
2019-09-04 20:13 nikita Assigned To nikita => Florian Dold
2019-09-04 20:14 nikita Note Added: 0014859
2019-09-04 20:20 nikita Note Added: 0014860
2019-09-04 20:46 nikita Note Added: 0014861
2019-09-04 20:46 nikita Assigned To Florian Dold => nikita
2019-09-05 16:39 Florian Dold Note Added: 0014866
2019-09-06 12:31 Florian Dold Status acknowledged => assigned
2019-09-16 09:30 Christian Grothoff Severity minor => tweak
2020-05-05 09:54 nikita Assigned To nikita =>
2020-05-05 11:05 Christian Grothoff Status assigned => confirmed
2020-10-11 21:09 Christian Grothoff Note Added: 0017010
2020-10-11 21:11 Christian Grothoff Note Added: 0017011
2020-10-11 21:11 Christian Grothoff Assigned To => Christian Grothoff
2020-10-11 21:11 Christian Grothoff Status confirmed => resolved
2020-10-11 21:11 Christian Grothoff Resolution open => fixed
2020-10-11 21:11 Christian Grothoff Fixed in Version => 0.8
2020-10-11 21:11 Christian Grothoff Product Version => git (master)
2020-10-11 21:11 Christian Grothoff Target Version => 0.8
2021-08-24 16:23 Christian Grothoff Status resolved => closed