View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005098 | Taler | Web site(s) | public | 2017-06-29 11:29 | 2020-03-31 16:04 |
| Reporter | Marcello Stanisci | Assigned To | nikita | ||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | reopened | ||
| Product Version | git (master) | ||||
| Target Version | 0.7.0 | Fixed in Version | 0.7.0 | ||
| Summary | 0005098: --prefix option would be useful | ||||
| Description | Given that now it is a BB worker which builds the site, it needs to copy all the HTML/CSS/static files in a separate directory. The woker does that becasue it wipes the local checkout before building the site, and that erases useful files too. So the useful files are to be copied in a safer place. A './confifure --prefix' option would save the BB worker from manually copying HTML/CSS/static file into the safer place. | ||||
| Tags | No tags attached. | ||||
| related to | 0005055 | closed | Marcello Stanisci | website updates (www, www-stage, docs) should go into buildbot and not into cron |
|
|
Ack, will get to this after GSoC. |
|
|
I don't think --prefix is the right way to do this. Websites that are served with python are already packaged like normal python packages, either installed globally or per-user. There's nothing more we need to do there. For websites that have just static files, the build system should produce a "dist" dir that contains all the files, and we then just need to copy this one directory instead of collecting together files manually. No need to complicate things with a --prefix argument and an "install" process that just copies data. |
|
|
Okay, this is what I did with gnunet.org |
|
|
I've switched the sh file used in the job for stage to copy file from the directory 'rendered' which contains all files (similar to how gnunet.org should be build once we have a buildbot doing this). Is this what you wanted, Marcello? |
|
|
I've actually revised my opinion on this issue. The landing.git repository already supports --prefix, and www.git should do so too. The main reason why I changed opinion on this matter is that we now have the taler-build-scripts.git, which makes setting up the build system to do this much easier and uniform across repositories. |
|
|
This is satisfied by recent config.mk and the install rule in www.git as far as I can see. running make install would mkdir and then cp to the prefix/share/taler-www |
|
|
Looks good to me. |
|
|
It's still not fixed, i need to work in the right path into the Makefile of www. Will close when done. |
|
|
instead of "hopping around" for stable/master, why don't we use a git worktree for one of the branches? this way we just have to cd to the directory and get rid of conflicting state (better would be to build in a different way) |
|
|
Not sure what you mean. We already have to separate checkouts for master and stable. Git's worktrees just allow us to have to branches checked out in some sub-folder of the same cloned repo. |
|
|
Okay. Then deployment really needs better documentation, I'm just going by buildbot logs. |
|
|
Why is this bug still open? Seems to work... |
|
|
I haven't done any bug triage recently. Closing as implemented. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-06-29 11:29 | Marcello Stanisci | New Issue | |
| 2017-06-29 11:29 | Marcello Stanisci | Relationship added | related to 0005055 |
| 2017-10-23 10:23 | Christian Grothoff | Severity | minor => tweak |
| 2017-10-23 10:23 | Christian Grothoff | Product Version | => git (master) |
| 2017-10-23 10:53 | Christian Grothoff | Status | new => confirmed |
| 2017-12-14 15:58 | Christian Grothoff | Target Version | => 0.7.1 |
| 2019-07-15 19:18 | nikita | Note Added: 0014683 | |
| 2019-07-15 19:18 | nikita | Assigned To | => nikita |
| 2019-07-15 19:18 | nikita | Status | confirmed => assigned |
| 2019-08-29 22:55 | Florian Dold | Note Added: 0014823 | |
| 2019-09-02 09:54 | nikita | Note Added: 0014833 | |
| 2019-09-03 16:55 | nikita | Note Added: 0014841 | |
| 2019-09-03 16:55 | nikita | Assigned To | nikita => Marcello Stanisci |
| 2019-11-01 23:22 | Florian Dold | Note Added: 0015047 | |
| 2019-11-01 23:22 | Florian Dold | Assigned To | Marcello Stanisci => nikita |
| 2019-12-14 13:54 | nikita | Note Added: 0015155 | |
| 2019-12-14 13:58 | Florian Dold | Status | assigned => resolved |
| 2019-12-14 13:58 | Florian Dold | Resolution | open => fixed |
| 2019-12-14 13:58 | Florian Dold | Note Added: 0015157 | |
| 2019-12-14 15:45 | nikita | Status | resolved => feedback |
| 2019-12-14 15:45 | nikita | Resolution | fixed => reopened |
| 2019-12-14 15:45 | nikita | Note Added: 0015159 | |
| 2019-12-14 16:04 | nikita | Note Added: 0015160 | |
| 2019-12-14 16:06 | Florian Dold | Note Added: 0015161 | |
| 2019-12-14 16:19 | nikita | Note Added: 0015162 | |
| 2019-12-25 12:05 | Christian Grothoff | Note Added: 0015221 | |
| 2020-01-20 15:24 | nikita | Status | feedback => resolved |
| 2020-01-20 15:24 | nikita | Note Added: 0015292 | |
| 2020-03-17 02:08 | Christian Grothoff | Fixed in Version | => 0.7.0 |
| 2020-03-17 02:08 | Christian Grothoff | Target Version | 0.7.1 => 0.7.0 |
| 2020-03-31 16:04 | Christian Grothoff | Status | resolved => closed |
