View Issue Details

IDProjectCategoryView StatusLast Update
0012017Talermerchant portal webuipublic2026-11-18 17:07
Reporterbot-cg [agent]  
CommunicatorCM_7  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
Target Version1.6Fixed in Version1.6 
Summary0012017: Merchant: Schedule a Report form does not focus its Description field
DescriptionWhat happens:
Reports -> '+ Schedule report' opens the create form (#/reports/new). Nothing is focused (BODY).

Expected:
The first field to fill, Description (#rep_desc_in), has focus.

Where:
  - packages/taler-merchant-webui/src/screens/ScheduleReportScreen.tsx:95
  - packages/taler-merchant-webui/src/screens/ScheduleReportScreen.tsx:182

Measured in headless Chromium (document.activeElement):
  before: BODY
  after: INPUT#rep_desc_in[text]

Proposed fix:
useRef on the description input and a mount-only effect that focuses it.

Patch against taler-typescript-core master attached; the same change is committed on branch dev/bots/autofocus (durian). Screenshots attached (focused element outlined in red): 'before' is master, 'after' is with the patch.

Verified: tsc ok for file; eslint/prettier clean; screens.test.js passes; screenshot confirms; tutorial chapter 14 preview does not steal focus (guard case)
TagsNo tags attached.
Attached Files
merchant-b--schedule-report-screen.diff (1,370 bytes)   
diff --git a/packages/taler-merchant-webui/src/screens/ScheduleReportScreen.tsx b/packages/taler-merchant-webui/src/screens/ScheduleReportScreen.tsx
index 14d32615f..892616635 100644
--- a/packages/taler-merchant-webui/src/screens/ScheduleReportScreen.tsx
+++ b/packages/taler-merchant-webui/src/screens/ScheduleReportScreen.tsx
@@ -24,7 +24,7 @@
  */
 
 import type { VNode } from "preact";
-import { useEffect, useMemo, useState } from "preact/hooks";
+import { useEffect, useMemo, useRef, useState } from "preact/hooks";
 import { useLocation } from "wouter-preact";
 import { Header } from "../ui/Header.js";
 import { useTranslation } from "../context/translation.js";
@@ -91,6 +91,12 @@ export function ScheduleReportScreen({
     }
   }, [reportSenderProgram, generatorEntries]);
 
+  // The description is the first thing this form asks for.
+  const descInput = useRef<HTMLInputElement>(null);
+  useEffect(() => {
+    descInput.current?.focus();
+  }, []);
+
   const done = () => setLocation("/reports/scheduled");
 
   const handleSubmit = async (e: Event) => {
@@ -173,6 +179,7 @@ export function ScheduleReportScreen({
             </label>
             <input
               {...fieldProps("rep_desc_in")}
+              ref={descInput}
               id="rep_desc_in"
               type="text"
               placeholder={t`e.g. Weekly sales summary`}

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0012002 closed Merchant portal: dialogs, PIN/code prompts and single-purpose forms open without keyboard focus on the obvious field 

Activities

bot-codex-florian-dold

2026-11-13 09:11

manager   ~0030466

commit e9ea0e569eda3ba61fd39a1617c7a970967326cd
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:16 2026 +0100

    merchant web UI: focus creation and refund forms
    
    Choose the first field for products, devices, access, bank accounts,
    orders and reports. Wait for refund and bank-monitoring data before
    focusing their controls; select the suggested order amount.
    
    Issue: https://bugs.taler.net/n/12006
    Issue: https://bugs.taler.net/n/12011
    Issue: https://bugs.taler.net/n/12012
    Issue: https://bugs.taler.net/n/12013
    Issue: https://bugs.taler.net/n/12014
    Issue: https://bugs.taler.net/n/12015
    Issue: https://bugs.taler.net/n/12016
    Issue: https://bugs.taler.net/n/12017
    Assisted-by: LLM

commit c1ee0c1022645200e605a3f36ab4910a3750c180
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:11 2026 +0100

    web-util: focus pages and form steps when their controls are ready
    
    FocusScope queues one initial focus request when a page, form or step
    opens. It waits for loading and cancels the request if the user moves
    focus. useFocusTarget retries pending focus when a control mounts.
    
    Explicit requestFocus calls run immediately and return success or
    failure.
    
    Issue: https://bugs.taler.net/n/12002
    Issue: https://bugs.taler.net/n/12024
    Assisted-by: LLM

Issue History

Date ModifiedUsernameFieldChange
2026-11-10 23:41bot-cgNew Issue
2026-11-10 23:41bot-cgRelationship addedchild of 0012002
2026-11-10 23:43bot-cgFile Added: merchant-b--schedule-report-screen.diff
2026-11-10 23:43bot-cgFile Added: merchant-b--schedule-report-screen--before.png
2026-11-10 23:43bot-cgFile Added: merchant-b--schedule-report-screen--after.png
2026-11-11 08:25Christian GrothoffSeverityminor => trivial
2026-11-13 09:11bot-codex-florian-doldNote Added: 0030466
2026-11-13 09:12bot-codex-florian-doldStatusnew => closed
2026-11-13 09:12bot-codex-florian-doldResolutionopen => fixed
2026-11-18 17:03Christian GrothoffTarget Version => 1.6
2026-11-18 17:07Christian GrothoffFixed in Version => 1.6