View Issue Details

IDProjectCategoryView StatusLast Update
0012014Talermerchant portal webuipublic2026-11-18 17:07
Reporterbot-cg [agent]  
CommunicatorCM_7  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
Target Version1.6Fixed in Version1.6 
Summary0012014: Merchant: 'Add a bank account' does not focus the IBAN
DescriptionWhat happens:
Bank accounts -> add: the method select comes first and already holds the usual choice; nothing is focused (BODY).

Expected:
Focus the account's first field (IBAN, or Bank Server Host for x-taler-bank).

Where:
  - packages/taler-merchant-webui/src/screens/AddPayoutAccountScreen.tsx:93

Measured in headless Chromium (document.activeElement):
  before: BODY
  after: INPUT#payout-iban

Proposed fix:
Form ref + mount effect calling focusFirstEmptyField (skips the select).

Patch against taler-typescript-core master attached; the same change is committed on branch dev/bots/autofocus (durian). Screenshots attached (focused element outlined in red): 'before' is master, 'after' is with the patch.

Verified: tsc ok; eslint clean; screenshot confirms. Depends on the untracked src/utils/focus.ts (focusFirstEmptyField).
TagsNo tags attached.
Attached Files
merchant-a--add-payout-account.diff (1,752 bytes)   
diff --git a/packages/taler-merchant-webui/src/screens/AddPayoutAccountScreen.tsx b/packages/taler-merchant-webui/src/screens/AddPayoutAccountScreen.tsx
index 5bceb98ee..05eeb19ad 100644
--- a/packages/taler-merchant-webui/src/screens/AddPayoutAccountScreen.tsx
+++ b/packages/taler-merchant-webui/src/screens/AddPayoutAccountScreen.tsx
@@ -16,7 +16,7 @@
 
 import { FormActionFooter, useFormFeedback } from "../ui/FormActionFooter.js";
 import type { VNode } from "preact";
-import { useEffect, useMemo, useState } from "preact/hooks";
+import { useEffect, useMemo, useRef, useState } from "preact/hooks";
 import {
   validateIban,
   Paytos,
@@ -30,6 +30,7 @@ import { ApiErrorBanner } from "../ui/ApiErrorBanner.js";
 import { normalizeUiFailure } from "../utils/errors.js";
 import type { RemoteResource } from "../api/contracts.js";
 import { ReadErrorBanner } from "../ui/ReadErrorBanner.js";
+import { focusFirstEmptyField } from "../utils/focus.js";
 
 export interface AddPayoutAccountScreenProps {
   paymentTargetTypes?: string;
@@ -87,6 +88,13 @@ export function AddPayoutAccountScreen({
     feedbackId,
   } = useFormFeedback();
 
+  // Start on the account's first field, past the method chooser, which
+  // already holds the usual choice.
+  const form = useRef<HTMLFormElement>(null);
+  useEffect(() => {
+    focusFirstEmptyField(form.current);
+  }, []);
+
   useEffect(() => {
     if (allowedMethods.length > 0 && !allowedMethods.includes(wireMethod)) {
       setWireMethod(allowedMethods[0]!);
@@ -170,6 +178,7 @@ export function AddPayoutAccountScreen({
       />
 
       <form
+        ref={form}
         onSubmit={handleSubmit}
         class="bg-white border border-gray-200 rounded-xl p-6 shadow-sm space-y-5"
       >

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0012002 closed Merchant portal: dialogs, PIN/code prompts and single-purpose forms open without keyboard focus on the obvious field 

Activities

bot-codex-florian-dold

2026-11-13 09:10

manager   ~0030463

commit e9ea0e569eda3ba61fd39a1617c7a970967326cd
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:16 2026 +0100

    merchant web UI: focus creation and refund forms
    
    Choose the first field for products, devices, access, bank accounts,
    orders and reports. Wait for refund and bank-monitoring data before
    focusing their controls; select the suggested order amount.
    
    Issue: https://bugs.taler.net/n/12006
    Issue: https://bugs.taler.net/n/12011
    Issue: https://bugs.taler.net/n/12012
    Issue: https://bugs.taler.net/n/12013
    Issue: https://bugs.taler.net/n/12014
    Issue: https://bugs.taler.net/n/12015
    Issue: https://bugs.taler.net/n/12016
    Issue: https://bugs.taler.net/n/12017
    Assisted-by: LLM

commit c1ee0c1022645200e605a3f36ab4910a3750c180
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:11 2026 +0100

    web-util: focus pages and form steps when their controls are ready
    
    FocusScope queues one initial focus request when a page, form or step
    opens. It waits for loading and cancels the request if the user moves
    focus. useFocusTarget retries pending focus when a control mounts.
    
    Explicit requestFocus calls run immediately and return success or
    failure.
    
    Issue: https://bugs.taler.net/n/12002
    Issue: https://bugs.taler.net/n/12024
    Assisted-by: LLM

commit fdb0b892c5ea5e4869edcc8b83fb43a707be2126
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:08 2026 +0100

    web-util: add helpers for initial focus and modal keyboard handling
    
    Find controls that can receive focus, skipping hidden, disabled and
    inert elements. Choose a dialog's initial focus from an explicit target,
    an editable field, or its first control.
    
    Handle Escape on the active dialog. For custom modals, keep Tab inside
    and make the rest of the page inert so it cannot receive clicks or
    focus. Restore the previous inert state on close. Let the browser handle
    Tab in native dialogs, and allow focus to leave menus.
    
    Issue: https://bugs.taler.net/n/12002
    Issue: https://bugs.taler.net/n/12024
    Assisted-by: LLM

Issue History

Date ModifiedUsernameFieldChange
2026-11-10 23:41bot-cgNew Issue
2026-11-10 23:41bot-cgRelationship addedchild of 0012002
2026-11-10 23:43bot-cgFile Added: merchant-a--add-payout-account.diff
2026-11-10 23:43bot-cgFile Added: merchant-a--add-payout-account--before.png
2026-11-10 23:43bot-cgFile Added: merchant-a--add-payout-account--after.png
2026-11-11 16:39Christian GrothoffSeveritytweak => trivial
2026-11-13 09:10bot-codex-florian-doldNote Added: 0030463
2026-11-13 09:12bot-codex-florian-doldStatusnew => closed
2026-11-13 09:12bot-codex-florian-doldResolutionopen => fixed
2026-11-18 17:03Christian GrothoffTarget Version => 1.6
2026-11-18 17:07Christian GrothoffFixed in Version => 1.6