View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012011 | Taler | merchant portal webui | public | 2026-11-10 23:41 | 2026-11-18 17:07 |
| Reporter | bot-cg [agent] | ||||
| Communicator | CM_7 | ||||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0012011: Merchant: 'Create New Product' does not focus Product Name | ||||
| Description | What happens: Inventory -> '+ Add a product' navigates to the create form; the clicked button unmounts and focus falls to BODY, so a keyboard user tabs through the whole sidebar to reach the form. Expected: In create mode focus Product Name; edit mode unchanged. Where: - packages/taler-merchant-webui/src/screens/CreateProductScreen.tsx:271 Measured in headless Chromium (document.activeElement): before: BODY after: INPUT#prod_name_input Proposed fix: Ref on #prod_name_input focused on mount when not editing. Patch against taler-typescript-core master attached; the same change is committed on branch dev/bots/autofocus (durian). Screenshots attached (focused element outlined in red): 'before' is master, 'after' is with the patch. Verified: tsc ok; eslint clean; screenshot confirms; tutorial preview does not take focus (LiveComponentPreview guard) | ||||
| Tags | No tags attached. | ||||
| Attached Files | merchant-a--create-product.diff (1,736 bytes)
diff --git a/packages/taler-merchant-webui/src/screens/CreateProductScreen.tsx b/packages/taler-merchant-webui/src/screens/CreateProductScreen.tsx
index 5e7db1df8..650429d4a 100644
--- a/packages/taler-merchant-webui/src/screens/CreateProductScreen.tsx
+++ b/packages/taler-merchant-webui/src/screens/CreateProductScreen.tsx
@@ -19,7 +19,7 @@ import type { RecordLoss } from "../utils/inventory.js";
import type { VNode } from "preact";
import { session } from "../stores/session.js";
import { Amounts } from "@gnu-taler/taler-util";
-import { useEffect, useState } from "preact/hooks";
+import { useEffect, useRef, useState } from "preact/hooks";
import { useLocation } from "wouter-preact";
import { Header } from "../ui/Header.js";
import { FormActionFooter, useFormFeedback } from "../ui/FormActionFooter.js";
@@ -266,6 +266,12 @@ function CreateProductForm({
// Form State (Spec 07 § 7.2)
const [name, setName] = useState<string>(existing?.name || "");
+ // A new product starts with its name. When editing, no field in particular
+ // comes first.
+ const nameInput = useRef<HTMLInputElement>(null);
+ useEffect(() => {
+ if (!isEditing) nameInput.current?.focus();
+ }, [isEditing]);
const [productId, setProductId] = useState<string>(existing?.id || "");
const [manualId, setManualId] = useState<boolean>(!!existing?.id);
const [description, setDescription] = useState<string>(
@@ -555,6 +561,7 @@ function CreateProductForm({
{t`Product Name`} <span class="text-red-500">*</span>
</label>
<input
+ ref={nameInput}
{...fieldProps("prod_name_input")}
id="prod_name_input"
type="text"
| ||||
| child of | 0012002 | closed | Merchant portal: dialogs, PIN/code prompts and single-purpose forms open without keyboard focus on the obvious field |
| commit e9ea0e569eda3ba61fd39a1617c7a970967326cd Author: Florian Dold <dold@taler.net> Date: Fri Nov 13 01:06:16 2026 +0100 merchant web UI: focus creation and refund forms Choose the first field for products, devices, access, bank accounts, orders and reports. Wait for refund and bank-monitoring data before focusing their controls; select the suggested order amount. Issue: https://bugs.taler.net/n/12006 Issue: https://bugs.taler.net/n/12011 Issue: https://bugs.taler.net/n/12012 Issue: https://bugs.taler.net/n/12013 Issue: https://bugs.taler.net/n/12014 Issue: https://bugs.taler.net/n/12015 Issue: https://bugs.taler.net/n/12016 Issue: https://bugs.taler.net/n/12017 Assisted-by: LLM commit c1ee0c1022645200e605a3f36ab4910a3750c180 Author: Florian Dold <dold@taler.net> Date: Fri Nov 13 01:06:11 2026 +0100 web-util: focus pages and form steps when their controls are ready FocusScope queues one initial focus request when a page, form or step opens. It waits for loading and cancels the request if the user moves focus. useFocusTarget retries pending focus when a control mounts. Explicit requestFocus calls run immediately and return success or failure. Issue: https://bugs.taler.net/n/12002 Issue: https://bugs.taler.net/n/12024 Assisted-by: LLM | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-11-10 23:41 | bot-cg | New Issue | |
| 2026-11-10 23:41 | bot-cg | Relationship added | child of 0012002 |
| 2026-11-10 23:43 | bot-cg | File Added: merchant-a--create-product.diff | |
| 2026-11-10 23:43 | bot-cg | File Added: merchant-a--create-product--before.png | |
| 2026-11-10 23:43 | bot-cg | File Added: merchant-a--create-product--after.png | |
| 2026-11-11 16:39 | Christian Grothoff | Severity | tweak => trivial |
| 2026-11-13 09:10 | bot-codex-florian-dold | Note Added: 0030460 | |
| 2026-11-13 09:12 | bot-codex-florian-dold | Status | new => closed |
| 2026-11-13 09:12 | bot-codex-florian-dold | Resolution | open => fixed |
| 2026-11-18 17:03 | Christian Grothoff | Target Version | => 1.6 |
| 2026-11-18 17:07 | Christian Grothoff | Fixed in Version | => 1.6 |