View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012010 | Taler | merchant portal webui | public | 2026-11-10 23:41 | 2026-11-18 17:07 |
| Reporter | bot-cg [agent] | ||||
| Communicator | CM_7 | ||||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0012010: Merchant: admin 'Create merchant account' form does not focus Account ID | ||||
| Description | What happens: Merchant accounts -> '+ Create merchant account' opens the create form; nothing is focused (BODY). Expected: In create mode focus Account ID; edit mode (ID locked, no obvious first field) unchanged. Where: - packages/taler-merchant-webui/src/screens/AdminAccountFormScreen.tsx:101 Measured in headless Chromium (document.activeElement): before: BODY after: INPUT#managed-account-id Proposed fix: Ref on #managed-account-id focused on mount when mode === 'create'. Patch against taler-typescript-core master attached; the same change is committed on branch dev/bots/autofocus (durian). Screenshots attached (focused element outlined in red): 'before' is master, 'after' is with the patch. Verified: tsc ok; eslint clean; screenshot confirms | ||||
| Tags | No tags attached. | ||||
| Attached Files | merchant-a--admin-create-account.diff (1,660 bytes)
diff --git a/packages/taler-merchant-webui/src/screens/AdminAccountFormScreen.tsx b/packages/taler-merchant-webui/src/screens/AdminAccountFormScreen.tsx
index 5fe1598f9..32e8e5eef 100644
--- a/packages/taler-merchant-webui/src/screens/AdminAccountFormScreen.tsx
+++ b/packages/taler-merchant-webui/src/screens/AdminAccountFormScreen.tsx
@@ -9,7 +9,7 @@
import { FormActionFooter, useFormFeedback } from "../ui/FormActionFooter.js";
import type { VNode } from "preact";
-import { useState } from "preact/hooks";
+import { useEffect, useRef, useState } from "preact/hooks";
import {
isValidMerchantInstanceId,
normalizeMerchantInstanceId,
@@ -96,6 +96,12 @@ function AdminAccountFormInner({
const { t } = useTranslation();
const [value, setValue] = useState<AdminAccountFormValue>(initial);
const [confirmPassword, setConfirmPassword] = useState("");
+ // A new account starts with its identifier. When editing, the identifier is
+ // fixed and no field in particular comes first.
+ const accountIdInput = useRef<HTMLInputElement>(null);
+ useEffect(() => {
+ if (mode === "create") accountIdInput.current?.focus();
+ }, [mode]);
const [showAdvancedRequested, setShowAdvanced] = useState(mode === "edit");
const [ignoreInvalidLogo, setIgnoreInvalidLogo] = useState(false);
const [customTiming, setCustomTiming] = useState(
@@ -256,6 +262,7 @@ function AdminAccountFormInner({
{t`Account ID`} *
</label>
<input
+ ref={accountIdInput}
{...fieldProps("managed-account-id")}
id="managed-account-id"
value={value.id}
| ||||
| child of | 0012002 | closed | Merchant portal: dialogs, PIN/code prompts and single-purpose forms open without keyboard focus on the obvious field |
| commit 460b2808ea3a4cd62a07cd9e9cb4ddced399872c Author: Florian Dold <dold@taler.net> Date: Fri Nov 13 01:06:16 2026 +0100 merchant web UI: focus merchant account and server setup forms Start account creation, password reset and server setup on the first field the user needs to fill. Issue: https://bugs.taler.net/n/12007 Issue: https://bugs.taler.net/n/12008 Issue: https://bugs.taler.net/n/12009 Issue: https://bugs.taler.net/n/12010 Assisted-by: LLM commit c1ee0c1022645200e605a3f36ab4910a3750c180 Author: Florian Dold <dold@taler.net> Date: Fri Nov 13 01:06:11 2026 +0100 web-util: focus pages and form steps when their controls are ready FocusScope queues one initial focus request when a page, form or step opens. It waits for loading and cancels the request if the user moves focus. useFocusTarget retries pending focus when a control mounts. Explicit requestFocus calls run immediately and return success or failure. Issue: https://bugs.taler.net/n/12002 Issue: https://bugs.taler.net/n/12024 Assisted-by: LLM | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-11-10 23:41 | bot-cg | New Issue | |
| 2026-11-10 23:41 | bot-cg | Relationship added | child of 0012002 |
| 2026-11-10 23:43 | bot-cg | File Added: merchant-a--admin-create-account.diff | |
| 2026-11-10 23:43 | bot-cg | File Added: merchant-a--admin-create-account--before.png | |
| 2026-11-10 23:43 | bot-cg | File Added: merchant-a--admin-create-account--after.png | |
| 2026-11-11 16:39 | Christian Grothoff | Severity | tweak => trivial |
| 2026-11-13 09:10 | bot-codex-florian-dold | Note Added: 0030459 | |
| 2026-11-13 09:12 | bot-codex-florian-dold | Status | new => closed |
| 2026-11-13 09:12 | bot-codex-florian-dold | Resolution | open => fixed |
| 2026-11-18 17:03 | Christian Grothoff | Target Version | => 1.6 |
| 2026-11-18 17:07 | Christian Grothoff | Fixed in Version | => 1.6 |