View Issue Details

IDProjectCategoryView StatusLast Update
0012009Talermerchant portal webuipublic2026-11-18 17:07
Reporterbot-cg [agent]  
CommunicatorCM_7  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
Target Version1.6Fixed in Version1.6 
Summary0012009: Merchant: admin 'Reset merchant account password' page does not focus New password
DescriptionWhat happens:
Admin -> account -> reset password: a page whose only purpose is entering the new password twice; nothing is focused (BODY).

Expected:
Focus New password.

Where:
  - packages/taler-merchant-webui/src/screens/AdminAccountCredentialsScreen.tsx:42

Measured in headless Chromium (document.activeElement):
  before: BODY
  after: INPUT#admin-reset-password[password]

Proposed fix:
Form ref + mount effect calling focusFirstEmptyField (from src/utils/focus.ts), since PasswordInput does not forward a ref.

Patch against taler-typescript-core master attached; the same change is committed on branch dev/bots/autofocus (durian). Screenshots attached (focused element outlined in red): 'before' is master, 'after' is with the patch.

Verified: tsc ok; eslint clean; screenshot confirms. Depends on the untracked src/utils/focus.ts (focusFirstEmptyField).
TagsNo tags attached.
Attached Files
merchant-a--admin-reset-password.diff (1,803 bytes)   
diff --git a/packages/taler-merchant-webui/src/screens/AdminAccountCredentialsScreen.tsx b/packages/taler-merchant-webui/src/screens/AdminAccountCredentialsScreen.tsx
index 8e4c5b9d0..f56d23b40 100644
--- a/packages/taler-merchant-webui/src/screens/AdminAccountCredentialsScreen.tsx
+++ b/packages/taler-merchant-webui/src/screens/AdminAccountCredentialsScreen.tsx
@@ -9,11 +9,12 @@
 
 import { FormActionFooter, useFormFeedback } from "../ui/FormActionFooter.js";
 import type { VNode } from "preact";
-import { useState } from "preact/hooks";
+import { useEffect, useRef, useState } from "preact/hooks";
 import { Header } from "../ui/Header.js";
 import { Button } from "../ui/Button.js";
 import { PasswordInput } from "../ui/PasswordInput.js";
 import { useTranslation } from "../context/translation.js";
+import { focusFirstEmptyField } from "../utils/focus.js";
 
 export function AdminAccountCredentialsScreen({
   instanceId,
@@ -37,6 +38,11 @@ export function AdminAccountCredentialsScreen({
     fieldError,
   } = useFormFeedback();
   const [pending, setPending] = useState(false);
+  // The new password is all this page asks for.
+  const form = useRef<HTMLFormElement>(null);
+  useEffect(() => {
+    focusFirstEmptyField(form.current);
+  }, []);
 
   const submit = async (event: Event) => {
     event.preventDefault();
@@ -79,6 +85,7 @@ export function AdminAccountCredentialsScreen({
       <div class="rounded-lg border border-amber-300 bg-amber-50 p-4 text-sm text-amber-950">{t`The account’s existing password will stop working. Existing login tokens remain governed by the backend’s token policy.`}</div>
 
       <form
+        ref={form}
         onSubmit={(event) => void submit(event)}
         class="space-y-5 rounded-xl border border-gray-200 bg-white p-5"
       >

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0012002 closed Merchant portal: dialogs, PIN/code prompts and single-purpose forms open without keyboard focus on the obvious field 

Activities

bot-codex-florian-dold

2026-11-13 09:10

manager   ~0030458

commit 460b2808ea3a4cd62a07cd9e9cb4ddced399872c
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:16 2026 +0100

    merchant web UI: focus merchant account and server setup forms
    
    Start account creation, password reset and server setup on the first
    field the user needs to fill.
    
    Issue: https://bugs.taler.net/n/12007
    Issue: https://bugs.taler.net/n/12008
    Issue: https://bugs.taler.net/n/12009
    Issue: https://bugs.taler.net/n/12010
    Assisted-by: LLM

commit c1ee0c1022645200e605a3f36ab4910a3750c180
Author: Florian Dold <dold@taler.net>
Date: Fri Nov 13 01:06:11 2026 +0100

    web-util: focus pages and form steps when their controls are ready
    
    FocusScope queues one initial focus request when a page, form or step
    opens. It waits for loading and cancels the request if the user moves
    focus. useFocusTarget retries pending focus when a control mounts.
    
    Explicit requestFocus calls run immediately and return success or
    failure.
    
    Issue: https://bugs.taler.net/n/12002
    Issue: https://bugs.taler.net/n/12024
    Assisted-by: LLM

Issue History

Date ModifiedUsernameFieldChange
2026-11-10 23:41bot-cgNew Issue
2026-11-10 23:41bot-cgRelationship addedchild of 0012002
2026-11-10 23:43bot-cgFile Added: merchant-a--admin-reset-password.diff
2026-11-10 23:43bot-cgFile Added: merchant-a--admin-reset-password--before.png
2026-11-10 23:43bot-cgFile Added: merchant-a--admin-reset-password--after.png
2026-11-11 16:39Christian GrothoffSeveritytweak => trivial
2026-11-13 09:10bot-codex-florian-doldNote Added: 0030458
2026-11-13 09:12bot-codex-florian-doldStatusnew => closed
2026-11-13 09:12bot-codex-florian-doldResolutionopen => fixed
2026-11-18 17:03Christian GrothoffTarget Version => 1.6
2026-11-18 17:07Christian GrothoffFixed in Version => 1.6