View Issue Details

IDProjectCategoryView StatusLast Update
0006540Talerwallet-corepublic2023-01-26 22:53
ReporterFlorian Dold Assigned ToFlorian Dold  
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.1Fixed in Version0.9.1 
Summary0006540: generate more info for insufficient balance on exchange/auditor mismatch or age restriction
DescriptionIn the "insufficient-balance" response, the wallet should additionally return:

(1) The current available balance in the requested currency
(2) The current available balance considering accepted exchange restrictions
(3) List of accepted exchanges and auditors

This should be sufficient to generate less confusing error messages when there is an auditor/exchange mismatch for the same currency.
TagsNo tags attached.

Activities

Christian Grothoff

2020-08-28 13:17

manager   ~0016785

I am not sure the above would be less confusing. I propose something simpler: *if* there is no auditor, then when reporting these kinds of issues, we always write ${CURRENCY}-${EXCHANGE_URL} to properly identify the exchange that issued the currency (for the amount held by the wallet). Similarly, for merchants, we should add the list of accepted exchanges (or auditors) as you propose.

For *audited* currencies (exchange or merchant) we should very explicitly include text in the error message that points out that the set of trusted auditors does not intersect.

Florian Dold

2020-08-28 14:39

manager   ~0016786

Regarding unaudited/regional currencies: Agreed, we've already discussed this and it's tracked in 0006448, but scheduled post-0.8

For audited currencies, I can simply improve the error message text, and give both sets (merchant-trusted and wallet-trusted auditors for the currency) in the "insufficient-balance" response.

So I guess I agree, the additional balance info isn't really required.

Florian Dold

2022-09-07 16:37

manager   ~0019101

Last edited: 2022-09-13 15:39

We now have the additional complication of age restrictions, and also need to consider that the merchant may not like particular exchanges due to the wire type specified in the contract terms.

I still think something along the following lines would be good:

Balance insufficient due to age restrictions:
"""
Insufficient balance: You have 10 EUR available, but {no balance, only 2 EUR} that satisfy the age restrictions (XY years) for this purchase.
"""

Merchant doesn't like exchange:

"""
Insufficient balance: You have 10 EUR available, but {no balance, only 2 EUR} from an exchange that works with this mechant.
<list of supported auditors/exchanges and wire type>
"""

Florian Dold

2023-01-06 13:56

manager   ~0019584

Implemented detailed wallet-core response for insufficient balance in 417c07f3f4.

Issue History

Date Modified Username Field Change
2020-08-28 11:05 Florian Dold New Issue
2020-08-28 11:05 Florian Dold Status new => assigned
2020-08-28 11:05 Florian Dold Assigned To => Florian Dold
2020-08-28 13:17 Christian Grothoff Note Added: 0016785
2020-08-28 14:39 Florian Dold Note Added: 0016786
2020-08-28 17:49 Christian Grothoff Severity minor => tweak
2022-09-07 16:30 Florian Dold Summary generate more info for insufficient balance on exchange/auditor mismatch => generate more info for insufficient balance on exchange/auditor mismatch or age restriction
2022-09-07 16:30 Florian Dold Description Updated
2022-09-07 16:37 Florian Dold Note Added: 0019101
2022-09-13 15:39 Florian Dold Note Edited: 0019101
2023-01-06 13:56 Florian Dold Status assigned => resolved
2023-01-06 13:56 Florian Dold Resolution open => fixed
2023-01-06 13:56 Florian Dold Note Added: 0019584
2023-01-23 22:25 Christian Grothoff Target Version => 0.9.1
2023-01-23 22:25 Christian Grothoff Fixed in Version => 0.9.1
2023-01-26 22:53 Christian Grothoff Status resolved => closed
2023-04-13 20:36 Florian Dold Category wallet (TS core) => wallet-core