From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Wed, 18 Nov 2026 16:01:54 +0100 Subject: [PATCH] libexchange: accept MELT history entries without transfer_pubs again The exchange omits transfer_pubs for legacy melts, and a mismatched length is already refused by the check at the start of parse_melt(). Issue: https://bugs.taler.net/n/12192 Assisted by LLM --- src/lib/exchange_api_get-coins-COIN_PUB-history.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib/exchange_api_get-coins-COIN_PUB-history.c b/src/lib/exchange_api_get-coins-COIN_PUB-history.c index dfb6a728f..f1cf9f780 100644 --- a/src/lib/exchange_api_get-coins-COIN_PUB-history.c +++ b/src/lib/exchange_api_get-coins-COIN_PUB-history.c @@ -286,6 +286,7 @@ parse_melt (struct CoinHistoryParseContext *pc, struct TALER_DenominationHashP *denoms_h = NULL; struct TALER_TransferPublicKeyP *transfer_pubs = NULL; size_t num_transfer_pubs = 0; + bool no_transfer_pubs; struct GNUNET_JSON_Specification spec[] = { TALER_JSON_spec_amount_any ("melt_fee", &rh->details.melt.melt_fee), @@ -315,7 +316,7 @@ parse_melt (struct CoinHistoryParseContext *pc, sizeof (struct TALER_TransferPublicKeyP), &num_transfer_pubs, (void **) &transfer_pubs), - NULL), + &no_transfer_pubs), GNUNET_JSON_spec_end () }; @@ -327,7 +328,8 @@ parse_melt (struct CoinHistoryParseContext *pc, GNUNET_break_op (0); return GNUNET_SYSERR; } - if (num_transfer_pubs != rh->details.melt.num_fresh_coins) + if ( (! no_transfer_pubs) && + (num_transfer_pubs != rh->details.melt.num_fresh_coins) ) { GNUNET_break_op (0); GNUNET_JSON_parse_free (spec); -- 2.47.3