From 7ae5cf2b850a9fcdc5628a09c75a250f8bd6f293 Mon Sep 17 00:00:00 2001 From: Christian Hesse Date: Thu, 8 Nov 2018 00:15:29 +0100 Subject: [PATCH 1/1] fix tests with curl Starting with curl 7.62.0 some tests fail. The commit in question is 46e16406 [0] ("url: use the URL API internally as well"). Analyzing the changed behavior reveals that the url given to curl_easy_setopt() with CURLOPT_URL is no longer encoded. Looking at the documentation [1] this behavior is correct, the "parameter should be a char * to a zero terminated string which must be URL-encoded [...]". So let's just give a valid url... [0] https://github.com/curl/curl/commit/46e164069d1a5230e4e64cbd2ff46c46cce056bb [1] https://curl.haxx.se/libcurl/c/CURLOPT_URL.html Signed-off-by: Christian Hesse --- src/testcurl/test_digestauth.c | 2 +- src/testcurl/test_digestauth_with_arguments.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/testcurl/test_digestauth.c b/src/testcurl/test_digestauth.c index 48c7a87a..89076608 100644 --- a/src/testcurl/test_digestauth.c +++ b/src/testcurl/test_digestauth.c @@ -218,7 +218,7 @@ testDigestAuth () { MHD_stop_daemon (d); return 32; } port = (int)dinfo->port; } - sprintf(url, "http://127.0.0.1:%d/bar%%20 foo?a=bü%%20", port); + sprintf(url, "http://127.0.0.1:%d/bar%20foo%3Fkey%3Dvalue", port); c = curl_easy_init (); curl_easy_setopt (c, CURLOPT_URL, url); curl_easy_setopt (c, CURLOPT_WRITEFUNCTION, ©Buffer); diff --git a/src/testcurl/test_digestauth_with_arguments.c b/src/testcurl/test_digestauth_with_arguments.c index 107d2256..17d0f7a2 100644 --- a/src/testcurl/test_digestauth_with_arguments.c +++ b/src/testcurl/test_digestauth_with_arguments.c @@ -213,7 +213,7 @@ testDigestAuth () { MHD_stop_daemon (d); return 32; } port = (int)dinfo->port; } - sprintf(url, "http://127.0.0.1:%d/foo?key=value", port); + sprintf(url, "http://127.0.0.1:%d/bar%20foo%3Fkey%3Dvalue", port); c = curl_easy_init (); curl_easy_setopt (c, CURLOPT_URL, url); curl_easy_setopt (c, CURLOPT_WRITEFUNCTION, ©Buffer);